refactor: remove dead code, consolidate save/error handling, add lint gate

1 files changed, 7 insertions, 7 deletions

diff --git a/internal/game/readiness_regression_test.go b/internal/game/readiness_regression_test.go
index 752b755..7fa2b2e 100644
--- a/internal/game/readiness_regression_test.go
+++ b/internal/game/readiness_regression_test.go
@@ -21,7 +21,7 @@ import (
 // bool/int pair is a data race and can lose the disconnect entirely.
 func TestDisconnectRaceIsFreeAndNeverLost(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("alice", "pw", false)
+	h.seedAccount("alice")
 	h.seedCharacter("alice", "alice")
 	sess, _ := h.connect("alice")
 
@@ -49,7 +49,7 @@ func TestDisconnectRaceIsFreeAndNeverLost(t *testing.T) {
 // takeable stock — never half-remove the ground with nothing delivered.
 func TestReservedPickupDoesNotDestroyItems(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("alice", "pw", false)
+	h.seedAccount("alice")
 	p := h.seedCharacter("alice", "alice")
 	writeSeedFile(t, filepath.Join(h.dir, "items", "chips.yaml"), []byte("id: chips\nname: chips\nstackable: true\n"))
 	sess := &net.Session{Conn: newChanConn(), Player: p, State: net.StateGame}
@@ -76,7 +76,7 @@ func TestReservedPickupDoesNotDestroyItems(t *testing.T) {
 // the crash and recovery still delivers the owed payout.
 func TestOwedPayoutSurvivesCharacterRename(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("acct", "pw", false)
+	h.seedAccount("acct")
 	p := h.seedCharacter("alice", "acct")
 	h.g.RunOnOwner(func() {
 		p.ID = "stable-char-id" // production characters carry a stable ID
@@ -132,7 +132,7 @@ func TestAccountRenamePreservesAccessAndOwnership(t *testing.T) {
 // round resolved, so recovery must not ALSO return the chip stake in kind.
 func TestSettledSurrenderDoesNotRefundChipStake(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("alice", "pw", false)
+	h.seedAccount("alice")
 	p := h.seedCharacter("alice", "alice")
 	h.g.RunOnOwner(func() {
 		p.Credits = 100
@@ -166,7 +166,7 @@ func TestSettledSurrenderDoesNotRefundChipStake(t *testing.T) {
 // recovery (after the disk is fixed) re-applies the owed payout.
 func TestRecoverySaveFailureRetriesOnNextStartup(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("alice", "pw", false)
+	h.seedAccount("alice")
 	p := h.seedCharacter("alice", "alice")
 	charDir := filepath.Join(h.dir, "players", "characters")
 	t.Cleanup(func() { os.Chmod(charDir, 0755) })
@@ -208,7 +208,7 @@ func TestRecoverySaveFailureRetriesOnNextStartup(t *testing.T) {
 // marker).
 func TestLostResolutionMarkerSurfacesAndRefunds(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("alice", "pw", false)
+	h.seedAccount("alice")
 	p := h.seedCharacter("alice", "alice")
 	h.g.RunOnOwner(func() {
 		p.Credits = 100
@@ -247,7 +247,7 @@ func TestLostResolutionMarkerSurfacesAndRefunds(t *testing.T) {
 // is not durable.
 func TestUnjournalablePayoutRefundsStake(t *testing.T) {
 	h := newHarness(t)
-	h.seedAccount("alice", "pw", false)
+	h.seedAccount("alice")
 	p := h.seedCharacter("alice", "alice")
 	h.g.RunOnOwner(func() {
 		p.Credits = 100