fix: close map OOM, admin traversal, transport safespot, room rekey, and legacy payout recovery

1 files changed, 22 insertions, 2 deletions

diff --git a/internal/game/cmd_map.go b/internal/game/cmd_map.go
index fc4ebf1..e84d1ce 100644
--- a/internal/game/cmd_map.go
+++ b/internal/game/cmd_map.go
@@ -2,14 +2,22 @@ package game
 
 import (
 	"thehouseoficarus/internal/net"
+	"thehouseoficarus/internal/player"
 )
 
 func (g *Game) executeMap(sess *net.Session, args []string, rawInput string) {
 	g.doMap(sess)
 }
 
-func (g *Game) doMap(sess *net.Session) {
-	p := sess.Player
+// maxMapDimension bounds the grid a player may request. buildFullMap
+// allocates mapHeight x mapWidth cells, so an unbounded option value would let
+// any authenticated player trigger a fatal (unrecoverable) out-of-memory
+// allocation that takes the whole server down. The option parser accepts any
+// int and the value persists in the account file, so the clamp must live here.
+const maxMapDimension = 200
+
+// mapDimensions returns the clamped map grid size requested by the player.
+func mapDimensions(p *player.Player) (int, int) {
 	mapWidth := p.OptionInt("map_width")
 	mapHeight := p.OptionInt("map_height")
 	if mapWidth < 5 {
@@ -18,6 +26,18 @@ func (g *Game) doMap(sess *net.Session) {
 	if mapHeight < 5 {
 		mapHeight = 5
 	}
+	if mapWidth > maxMapDimension {
+		mapWidth = maxMapDimension
+	}
+	if mapHeight > maxMapDimension {
+		mapHeight = maxMapDimension
+	}
+	return mapWidth, mapHeight
+}
+
+func (g *Game) doMap(sess *net.Session) {
+	p := sess.Player
+	mapWidth, mapHeight := mapDimensions(p)
 
 	lines := buildFullMap(g, sess, p.RoomID, mapWidth, mapHeight, mapGlyphsForPlayer(p.OptionBool("unicode")))