refactor: remove dead code, consolidate save/error handling, add lint gate

1 files changed, 7 insertions, 7 deletions

diff --git a/internal/game/cmd_bank.go b/internal/game/cmd_bank.go
index 86057cc..8da6e89 100644
--- a/internal/game/cmd_bank.go
+++ b/internal/game/cmd_bank.go
@@ -163,7 +163,7 @@ func (g *Game) doBankDeposit(sess *net.Session, input string) {
 		MaxQuality: slot.MaxQuality,
 	})
 
-	g.AccountStore.SaveCharacter(p)
+	g.saveCharacter(p)
 
 	displayName := itemID
 	if def != nil {
@@ -202,7 +202,7 @@ func (g *Game) doBankDepositAll(sess *net.Session) {
 		return
 	}
 
-	g.AccountStore.SaveCharacter(p)
+	g.saveCharacter(p)
 
 	sess.WriteLine(fmt.Sprintf("You deposit %d item%s.", deposited, plural(deposited)))
 }
@@ -300,7 +300,7 @@ func (g *Game) withdrawBankItem(sess *net.Session, p *player.Player, bankSlotIdx
 				slot.Quality == bs.Quality && slot.MaxQuality == bs.MaxQuality {
 				slot.Quantity += bs.Quantity
 				p.SetBankSlot(bankSlotIdx, nil)
-				g.AccountStore.SaveCharacter(p)
+				g.saveCharacter(p)
 				displayName := bs.ItemID
 				if def != nil {
 					displayName = def.Name
@@ -327,7 +327,7 @@ func (g *Game) withdrawBankItem(sess *net.Session, p *player.Player, bankSlotIdx
 		p.SetInvSlot(freeSlot, &player.InventorySlot{ItemID: itemID, Quantity: 1, Quality: bs.Quality, MaxQuality: bs.MaxQuality})
 		if qty > 1 {
 			bs.Quantity--
-			g.AccountStore.SaveCharacter(p)
+			g.saveCharacter(p)
 			displayName := itemID
 			if def != nil {
 				displayName = def.Name
@@ -339,7 +339,7 @@ func (g *Game) withdrawBankItem(sess *net.Session, p *player.Player, bankSlotIdx
 	}
 
 	p.SetBankSlot(bankSlotIdx, nil)
-	g.AccountStore.SaveCharacter(p)
+	g.saveCharacter(p)
 
 	displayName := itemID
 	if def != nil {
@@ -370,7 +370,7 @@ func (g *Game) doBankDepositCredits(sess *net.Session, parts []string) {
 	}
 	p.Credits -= amount
 	p.BankedCredits += amount
-	g.AccountStore.SaveCharacter(p)
+	g.saveCharacter(p)
 	sess.WriteLine(g.colorize(sess, "currency_pickup", fmt.Sprintf("You deposit %s credits. (Banked: %s)", formatInt(amount), formatInt(p.BankedCredits))))
 	g.showBankBrowse(sess)
 }
@@ -392,7 +392,7 @@ func (g *Game) doBankWithdrawCredits(sess *net.Session, parts []string) {
 	}
 	p.BankedCredits -= amount
 	p.Credits += amount
-	g.AccountStore.SaveCharacter(p)
+	g.saveCharacter(p)
 	sess.WriteLine(g.colorize(sess, "currency_pickup", fmt.Sprintf("You withdraw %s credits.", formatInt(amount))))
 	g.showBankBrowse(sess)
 }