From 775b716d86f5e681807698522e56c3d0f861c5bf Mon Sep 17 00:00:00 2001 From: historia Date: Tue, 25 Aug 2026 16:49:36 -0400 Subject: feat: combine --speaker and --voice for clarity --- app/tests/test_hub.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'app/tests/test_hub.py') diff --git a/app/tests/test_hub.py b/app/tests/test_hub.py index c5ca346..965cbaa 100644 --- a/app/tests/test_hub.py +++ b/app/tests/test_hub.py @@ -754,7 +754,8 @@ class ConvertFlowTests(unittest.TestCase): def test_audiocpp_customvoice_entry_lists_builtin_speakers(self): # A CustomVoice entry populates the Voice menu with the Qwen3-TTS - # built-in speakers and maps the pick to --speaker. + # built-in speakers and maps the pick to --voice (which the client + # resolves as speaker mode). self._patch_remote( [{"id": "Qwen3-TTS-12Hz-1.7B-CustomVoice-GGUF", "family": "qwen3_tts", "task": "tts"}]) @@ -765,9 +766,9 @@ class ConvertFlowTests(unittest.TestCase): audiocpp_voice="Ryan", instructions="") cmd = self._convert( None, [self._remote("audiocpp", "audio.cpp")]) - # The speaker is passed as --speaker, not --voice. - self.assertIsNone(cmd[2]["voice"]) - self.assertEqual(cmd[2]["speaker"], "Ryan") + # The picked speaker is passed as --voice; no separate speaker kwarg. + self.assertEqual(cmd[2]["voice"], "Ryan") + self.assertNotIn("speaker", cmd[2]) fields = self.tui.forms_seen[0][1] voice_field = self._field("audiocpp_voice") self.assertEqual(voice_field["choices"](fields), @@ -792,7 +793,7 @@ class ConvertFlowTests(unittest.TestCase): cmd = self._convert( None, [self._remote("audiocpp", "audio.cpp")]) self.assertEqual(cmd[2]["voice"], "narrator") - self.assertIsNone(cmd[2]["speaker"]) + self.assertNotIn("speaker", cmd[2]) self.assertIsNone(cmd[2]["instructions"]) fields = self.tui.forms_seen[0][1] voice_field = self._field("audiocpp_voice") @@ -815,7 +816,7 @@ class ConvertFlowTests(unittest.TestCase): None, [self._remote("audiocpp", "audio.cpp")]) self.assertIsNotNone(cmd) self.assertIsNone(cmd[2]["voice"]) - self.assertIsNone(cmd[2]["speaker"]) + self.assertNotIn("speaker", cmd[2]) voice_field = self._field("audiocpp_voice") # Clone-only: an empty voice is refused (no built-in speaker option). self.assertIsNotNone(voice_field["validate"]("")) @@ -948,8 +949,7 @@ class ConvertFlowTests(unittest.TestCase): return_value=root), \ patch.object(hub.config, "AUDIOCPP_INSTRUCTIONS", ""): self._answer_form(backend="audiocpp", model_id="qwen", - audiocpp_voice="(built-in speaker)", - instructions="") + audiocpp_voice="", instructions="") cmd = self._convert(None, [ self._ready("audiocpp", "audio.cpp"), self._remote("audiocpp", "audio.cpp")]) -- cgit v1.2.3